Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check brew install paths for socket_vmnet #15701

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Check brew install paths for socket_vmnet #15701

merged 4 commits into from
Jan 25, 2023

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jan 24, 2023 •
edited
Loading

Before:
If no socket_vmnet flags were provided minikube would check the install path if socket_vmnet was installed from source.

After:
If no socket_vmnet flags are provided minikube checks the source, brew amd64, and brew arm64 install paths for socket_vmnet.

Info:
socket_vmnet_client relative path: /opt/socket_vmnet/bin/socket_vmnet_client
socket_vmnet relative path: /var/run/socket_vmnet

source install path prefix: <none>
arm64 brew install path prefix: /opt/homebrew
amd64 brew install path prefix: /usr/local

Before:

# socket_vmnet installed via brew

minikube start --driver qemu --network socket_vmnet
😄  minikube v1.28.0 on Darwin 13.1 (arm64)
✨  Using the qemu2 driver based on user configuration

🙈  Exiting due to NOT_FOUND_SOCKET_VMNET: 


💡  Suggestion: 

    socket_vmnet was not found on the system, resolve by:
    
    Option 1) Installing socket_vmnet:
    
    https://minikube.sigs.k8s.io/docs/drivers/qemu/#networking
    
    Option 2) Using the user network:
    
    minikube start --driver qemu --network user

After:

# socket_vmnet installed via brew

$ minikube start --driver qemu --network socket_vmnet
😄  minikube v1.28.0 on Darwin 13.1 (arm64)
✨  Using the qemu2 driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating qemu2 VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.26.1 on Docker 20.10.22 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 24, 2023
medyagh
medyagh requested changes Jan 24, 2023
View reviewed changes
cmd/minikube/cmd/start_flags.go Outdated Show resolved Hide resolved
pkg/minikube/detect/detect.go Outdated Show resolved Hide resolved
pkg/minikube/detect/detect.go Outdated Show resolved Hide resolved
pkg/minikube/detect/detect.go Outdated Show resolved Hide resolved
pkg/minikube/detect/detect.go Show resolved Hide resolved
medyagh
medyagh requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after adding the comments it looks good to be merged

pkg/minikube/detect/detect.go Outdated Show resolved Hide resolved
@medyagh medyagh self-requested a review January 24, 2023 22:00
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2023
@medyagh medyagh merged commit 6fdb2e1 into kubernetes:master Jan 25, 2023
@spowelljr spowelljr deleted the checkBrewInstall branch January 25, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spowelljr @k8s-ci-robot @medyagh